Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all static tensor shapes in EvalSlice folder #2557

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

mvpant
Copy link
Contributor

@mvpant mvpant commented Sep 23, 2024

This patch enhances the EvalSlice constant folder to support all operator configurations on static tensor shapes, including 0-rank scalars.

@sdasgup3 sdasgup3 self-requested a review September 23, 2024 17:15
@sdasgup3
Copy link
Member

@mvpant Sorry for the delay. I will review this EOD.

Copy link
Member

@GleasonK GleasonK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will let Sandeep take a look as well.

@mvpant
Copy link
Contributor Author

mvpant commented Sep 27, 2024

@mvpant Sorry for the delay. I will review this EOD.

No problem, thanks!

@sdasgup3 sdasgup3 merged commit 1c0547f into openxla:main Sep 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants